I'll look into that case a bit this weekend if I can get the chance, I have a busy schedule right now. My original patch did a series of renames (though it had some other issues):<br><a href="http://www.winehq.org/pipermail/wine-patches/2007-February/036394.html">
http://www.winehq.org/pipermail/wine-patches/2007-February/036394.html</a><br>However, talking with Felix Nawothnig on wine-devel he suggested I re-write it, and over time his suggestions evolved into the revised form I submitted.
<br><br>Erich Hoover<br><a href="mailto:ehoover@mines.edu">ehoover@mines.edu</a><br><br><div><span class="gmail_quote">On 4/3/07, <b class="gmail_sendername">Dan Kegel</b> <<a href="mailto:dank@kegel.com">dank@kegel.com
</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Kudos for your persistance. I hope this makes it in soon.<br><br>I see two remaining problems:
<br><br>+ /*<br>+ * This case should never occur, we've already checked<br>permissions earlier<br>+ * and we are holding the file handle open.<br>+ */<br>+ ERR("Replacement file may not be deleted!\n");
<br><br>You need to handle this case better; it happens in real<br>life sometimes that the filesystem lies when it tells<br>you you can write. It should be a WARN, and you<br>need to return the proper error code.<br><br>
Are you quite sure you need to do any file copying?<br>Wouldn't a series of renames be more efficient?<br>- Dan<br></blockquote></div><br>