Hi,<br><br>Working on a D3D game, I have found that wine is refusing to load the following <br>manifest file (when Windows does not fail).<br><br><?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<br><!-- Copyright © 1981-2001 Microsoft Corporation --><br><assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"><br> <noInheritable/><br> <assemblyIdentity type="win32" name="
Microsoft.VC80.OpenMP" version="8.0.50727.42" processorArchitecture="x86" publicKeyToken="1fc8b3b9a1e18e3b"/><br> <file name="vcomp.dll" hash="0d009725bd5653af143fdfd9d8abf8adad533d16" hashalg="SHA1"/>
<br></assembly><br><br>Adding verbosity to actctx.c, it seems that this game is requesting version 8.0.50608.0, which does match major.minor, <br>but not the whole version number (<i>major.minor.build.revision)</i>.
<br><br>trace:actctx:parse_assembly_identity_elem name=L"Microsoft.VC80.OpenMP" version=8.0.50727.42 arch=L"x86"<br>fixme:actctx:parse_assembly_elem VERBOSE: wrong version FOUND: 8/0/50727/42<br>fixme:actctx:parse_assembly_elem VERBOSE: wrong version EXP: 8/0/50608/0
<br>fixme:actctx:parse_manifest_buffer failed to parse manifest L"C:\\Program Files\\Microsoft.VC80.OpenMP.manifest"<br>fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.OpenMP
"<br><br>According to MSDN, it seems only major.minor is considered for version matching:<br>- <a href="http://msdn2.microsoft.com/en-us/library/aa374234.aspx">http://msdn2.microsoft.com/en-us/library/aa374234.aspx</a>
: A version number that changes only in the <i>build</i> or <i>revision</i> parts indicates that the assembly is backward compatible with prior versions.<br>- <a href="http://msdn2.microsoft.com/en-us/library/aa375365.aspx">
http://msdn2.microsoft.com/en-us/library/aa375365.aspx</a>: [...]
are manifests used to redirect the version of a side-by-side assembly
to another compatible version. The version that the assembly is being
redirected to should have the same major.minor values as the original
version. <br><br>I am proposing the following one-liner to ntdll/actctx.c:<br><br>isa@isa:~/downloads/tmp$ diff -u wine-0.9.49/dlls/ntdll/actctx.c /home/isa/downloads/wine-0.9.49/dlls/ntdll/actctx.c<br>--- wine-0.9.49/dlls/ntdll/actctx.c 2007-11-09 17:56:
12.000000000 +0100<br>+++ /home/isa/downloads/wine-0.9.49/dlls/ntdll/actctx.c 2007-11-19 21:07:35.000000000 +0100<br>@@ -1390,8 +1390,8 @@<br> if (expected_ai)<br> {<br> /* FIXME: more tests */
<br>- if (assembly->type == ASSEMBLY_MANIFEST &&<br>- memcmp(&assembly->id.version, &expected_ai->version, sizeof(assembly->id.version)))<br>+ if (assembly->type == ASSEMBLY_MANIFEST &&
<br>+ ((assembly->id.version.major != expected_ai->version.major) || (assembly->id.version.minor != expected_ai->version.minor)) )<br> {<br> FIXME("wrong version\n");
<br> return FALSE;<br><br>With this patch, the manifest (and related DLL) is loading correctly. <br>This does not prevent my game die shortly after, in D3D code this time. Still work to do ;-)<br><br>Thanks,
<br><br>Norbert Lataille<br>