On Wed, Apr 9, 2008 at 10:02 PM, Dmitry Timoshkov <<a href="mailto:dmitry@codeweavers.com">dmitry@codeweavers.com</a>> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
"Erich Hoover" <<a href="mailto:ehoover@mines.edu" target="_blank">ehoover@mines.edu</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
+ oldError = GetLastError();<br>
+ /* Read and Write sharing are necessary if a flush is performed on an open file */<br>
+ hFile = CreateFileW(CurProfile->filename, GENERIC_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);<br>
if (hFile == INVALID_HANDLE_VALUE)<br>
{<br>
WARN("could not save profile file %s (error was %d)\n", debugstr_w(CurProfile->filename), GetLastError());<br>
return FALSE;<br>
}<br>
+ /* The operation has succeed, do not over-write the error code */<br>
+ SetLastError(oldError);<br>
</blockquote>
<br>
It's been said many times that if you need to save/restore last error value<br>
you are doing something wrong.</blockquote><div><br>Well, I could call NtCreateFile directly so that the error code never gets set in the first place...<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
+ /* Get* routines set S_OK on success, Write* routines return last error */<br>
+ SetLastError(S_OK);<br>
</blockquote>
<br>
There is no point in setting or checking last error value on success in vast<br>
majority of cases, do you have an app that depends on this? Besides, S_OK is<br>
an OLE error code and can not be used in kernel.<br>
</blockquote><div><br>This was done to satisfy a problem pointed out in the previous attempt, that patch broke a test in test_profile_sections where it checks that GetPrivateProfileSectionA()'s GetLastError() is S_OK. I figured that the code should be consistent with the (existing) test, if you think it's more appropriate then both could be changed to ERROR_SUCCESS.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
-- <br><font color="#888888">
Dmitry. <br>
</font></blockquote></div><br>