On 4/26/08, <b class="gmail_sendername">Lei Zhang</b> <<a href="mailto:thestig@google.com">thestig@google.com</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Sat, Apr 26, 2008 at 10:37 AM, Lei Zhang <<a href="mailto:thestig@google.com">thestig@google.com</a>> wrote:<br> ><br> > On Wed, Apr 23, 2008 at 5:59 AM, Alexandre Julliard <<a href="mailto:julliard@winehq.org">julliard@winehq.org</a>> wrote:<br>
> > Module: wine<br> > > Branch: master<br> > > Commit: faaccca59be08be547ec4e1948b6306eff3808a2<br> > > URL: <a href="http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e1948b6306eff3808a2">http://source.winehq.org/git/wine.git/?a=commit;h=faaccca59be08be547ec4e1948b6306eff3808a2</a><br>
> ><br> > > Author: Dan Kegel <<a href="mailto:dank@kegel.com">dank@kegel.com</a>><br> > > Date: Tue Apr 22 17:56:36 2008 -0700<br> > ><br> > > winecfg: Restrict dpi slider to sane values.<br>
> ><br> > > ---<br> > ><br> > > programs/winecfg/x11drvdlg.c | 4 ++--<br> > > 1 files changed, 2 insertions(+), 2 deletions(-)<br> > ><br> > > diff --git a/programs/winecfg/x11drvdlg.c b/programs/winecfg/x11drvdlg.c<br>
> > index bfa6ec5..c0ec058 100644<br> > > --- a/programs/winecfg/x11drvdlg.c<br> > > +++ b/programs/winecfg/x11drvdlg.c<br> > > @@ -35,9 +35,9 @@<br> > ><br> > > WINE_DEFAULT_DEBUG_CHANNEL(winecfg);<br>
> ><br> > > -#define RES_MAXLEN 5 /* the maximum number of characters in a screen dimension. 5 digits should be plenty, what kind of crazy person runs their screen >10,000 pixels across? */<br> > > +#define RES_MAXLEN 5 /* max number of digits in a screen dimension. 5 digits should be plenty */<br>
> > #define MINDPI 96<br> > > -#define MAXDPI 480<br> > > +#define MAXDPI 144 /* making this too high surprises and hurts users */<br> > > #define DEFDPI 96<br> > ><br> > > #define IDT_DPIEDIT 0x1234<br>
> ><br> > ><br> > ><br> > ><br> ><br> > Dan, this basically reverted commit<br> > 0110512904d9c646abef416819a057c06d3f2c97, which bumped MAXDPI from 160<br> > to 480 because some users specifically requested the ability for<br>
> higher DPI settings.<br> ><br> > I think we need to decide what we want and stop the tug-o-war.<br> ><br> <br> <br>Please see bug 9715.<br> <br> <br> </blockquote></div>The change was specifically requested. A warning if someone sets it over 150, or a small explanation in winecfg would be better IMHO.<br>