<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:times new roman, new york, times, serif;font-size:12pt"><div><pre>Thanks for reviewing the patch James<br>@@ -6,7 +6,7 @@<br> 8 stub ADsBuildVarArrayInt<br> 9 stdcall ADsOpenObject(wstr wstr wstr long ptr ptr)<br> 12 stub ADsSetLastError<br>-13 stub ADsGetLastError<br>+13 stdcall ADsGetLastError(ptr wstr long wstr long)<br><br><br>>Both of those wstr parameters are out pointers so they should be ptr, not wstr.<br><br>Didn't know that, so that has to be changed for sure<br><br> /*****************************************************<br>+ * ADsGetLastError [ACTIVEDS.13]<br>+ */<br>+HRESULT WINAPI ADsGetLastError(LPDWORD pError, LPWSTR buffer, DWORD<br>buflen, LPWSTR bufname, DWORD bufnamelen)<br>+{<br>+ FIXME("(%p,%p,%d,%p,%d)stub\n", pError, buffer, buflen, bufname,<br>bufnamelen);<br>+ return E_POINTER;<br>+}<br><br>>Returning E_POINTER
seems pretty wrong.<br><br>In the documentation on http://msdn.microsoft.com/en-us/library/aa772183(VS.85).aspx<br>it is listed as one of the possible return values. Of course one could also return E_NOTIMPL or E_FAIL etc, but for a stub this seemed like a good choice to me as well, the application (Dameware) doesn't seem to bother what is returned, it starts up just fine<br><br></pre></div></div><br>Send instant messages to your online friends http://uk.messenger.yahoo.com </body></html>