<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:times new roman, new york, times, serif;font-size:12pt"><div><br></div><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;"><br><div style="font-family: arial,helvetica,sans-serif; font-size: 13px;">----- Original Message ----<br>From: Alexandre Julliard <julliard@winehq.org><br>To: Louis. Lenders <xerox_xerox2000@yahoo.co.uk><br>Cc: wine-devel@winehq.org<br>Sent: Friday, 22 August, 2008 4:54:49 AM<br>Subject: Re: user32: fix error setting in FindWindow (try 2)<br><br>"Louis. Lenders" <<a ymailto="mailto:xerox_xerox2000@yahoo.co.uk" href="mailto:xerox_xerox2000@yahoo.co.uk">xerox_xerox2000@yahoo.co.uk</a>> writes:<br><br>> diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c<br>> index 1964e88..246347f 100644<br>> --- a/dlls/user32/tests/win.c<br>> +++
b/dlls/user32/tests/win.c<br>> @@ -4789,14 +4789,20 @@ static void test_hwnd_message(void)<br>> SetLastError(0xdeadbeef);<br>> found = FindWindowExA( GetDesktopWindow(), 0, 0, "message window" );<br>> ok( found == 0, "found message window %p/%p\n", found, hwnd );<br>> - todo_wine<br>> - ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError());<br>> + ok(GetLastError() == ERROR_FILE_NOT_FOUND, "ERROR_FILE_NOT_FOUND, got %d\n", GetLastError());<br><br>>Have you tried your test on Windows? According to the test results<br>>there isn't any Windows version that sets last error here.<br><br>If you're talking about the test above, that was a test written by someone else, i think it was committed on wednesday or so. I only take out the "todo_wine" there; <br>i assumed that test
passed on windows, as the patch was committed, but i now see on the test results page that it doesn't. <br><br>I did run the test on windows yesterday , the whole console got spammed with lots of messages, and i guess i overlooked something then ( i now see on the testpage that the failing test appears in the first lines of the spam, i only overlooked the last part in the console as i expected an eventually failing test there) <br><br>As FindWindowEx apparently doesn't set an error, I'll have to recheck what FindWindow does on windows<br><br></div></div></div><br>Send instant messages to your online friends http://uk.messenger.yahoo.com </body></html>