<div dir="ltr"><br><div class="gmail_quote">On Thu, Aug 21, 2008 at 9:41 PM, Stefan Dösinger <span dir="ltr"><<a href="mailto:stefan@codeweavers.com">stefan@codeweavers.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
These changes may be correct, but they need a test. Take a look at dlls/d3d9/tests/device.c to see how the other tests look. I guess the changes are likely to be correct, but they have to be tested</blockquote><div><br><br>
I'll add a test case and get back to you later then, thanks for the help.<br><br><div class="gmail_quote">On Thu, Aug 21, 2008 at 9:51 PM, H. Verbeet <span dir="ltr"><<a href="mailto:hverbeet@gmail.com">hverbeet@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <br>Not in its current form, there's a C++ comment and trailing spaces in<br>
there, and the change in SetScissorRect() probably should test if the<br>
rectangle is empty. Also, if it tests for empty rectangles, it should<br>
probably also test for rectangles that are (partially) outside the<br>
screen, etc.</blockquote><div><br>I'll change the code around and add the checking you mentioned.<br><br>Thanks for the info.<br><br>Regards,<br>Andrew<br></div></div></div></div></div>