<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
James Hawkins wrote:
<blockquote
cite="mid:22821af30810091554q62d3d73cia7bea8ae210c7c2d@mail.gmail.com"
type="cite">
<pre wrap="">On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <a class="moz-txt-link-rfc2396E" href="mailto:andrey.turkin@gmail.com"><andrey.turkin@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">[now with tests, fixed and reformatted as per James' suggestions]
Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW
stubs and few tests for them. Required for MSN Messenger 7.0
---
dlls/advapi32/advapi32.spec | 4 +-
dlls/advapi32/cred.c | 160 +++++++++++++++++++++++++++++++++++++++++++
dlls/advapi32/tests/cred.c | 45 ++++++++++++
include/wincred.h | 39 +++++++++++
4 files changed, 246 insertions(+), 2 deletions(-)
</pre>
</blockquote>
<pre wrap=""><!---->
+ *Size = 0;
+ *Credentials = NULL;
+ if (!TargetInformation)
What if Size or Credentials is NULL? You should add a test for that
and handle it appropriately. If the tests crash, you should comment
out the tests and note that there is no handling in Windows.
</pre>
</blockquote>
<br>
Why? Windows does the same thing, tests would crash. Do you really
think somebody need to know this? Is there any application that depends
on this behavior so these assignments must be commented to protect them
from change? I can't see any value in commented out test or
sort-of-meaningless code comment.<br>
</body>
</html>