It does match the style of the way that HeapAlloc is used elsewhere in
the file, though not malloc admittedly. I wasn't sure which convention
had precedent.<br><br>I'm afraid that I don't understand how my
changelog doesn't match the patch. I'm new here, can you help me out?
There's obviously something I'm missing!<br>
<br>Pete<br><br><div class="gmail_quote">2008/10/30 James Hawkins <span dir="ltr"><<a href="mailto:truiken@gmail.com">truiken@gmail.com</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="Wj3C7c">On Wed, Oct 29, 2008 at 7:39 PM, Pete Myers<br>
<<a href="mailto:peterdanielmyers@googlemail.com">peterdanielmyers@googlemail.com</a>> wrote:<br>
> In line with <a href="http://wiki.winehq.org/ReplaceMalloc" target="_blank">http://wiki.winehq.org/ReplaceMalloc</a> this is a small patch that<br>
> changes all malloc calls to HeapAlloc in the following files:<br>
> ./dlls/iphlpapi/tests/iphlpapi.c<br>
> ./dlls/wnaspi32/winaspi16.c<br>
><br>
> Changelog:<br>
> * malloc calls in dlls/kernel32/process.c have been change to HeapAlloc<br>
><br>
<br>
</div></div>Your changelog (right above) doesn't match the patch, and<br>
<br>
- PMIB_IPADDRTABLE buf = (PMIB_IPADDRTABLE)malloc(dwSize);<br>
+ PMIB_IPADDRTABLE buf = (PMIB_IPADDRTABLE)HeapAlloc(<br>
GetProcessHeap(), 0, dwSize);<br>
<br>
You've introduced a space after opening parentheses which does not<br>
match the style of the rest of the file.<br>
<br>
--<br>
<font color="#888888">James Hawkins<br>
</font></blockquote></div><br>