<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
</style>
</head>
<body class='hmmessage'>
> Date: Tue, 18 Nov 2008 10:17:46 +0100<BR>> From: meissner@suse.de<BR>> To: dmitry@codeweavers.com<BR>> CC: ricardo_barbano@hotmail.com; wine-devel@winehq.org<BR>> Subject: Re: dlls/cabinet: fix dead stores (llvm/clang)<BR>> <BR>> On Tue, Nov 18, 2008 at 03:11:52PM +0800, Dmitry Timoshkov wrote:<BR>> > "ricardo filipe" <ricardo_barbano@hotmail.com> wrote:<BR>> > <BR>> > > --- a/dlls/cabinet/fci.c<BR>> > > +++ b/dlls/cabinet/fci.c<BR>> > > @@ -462,7 +462,7 @@ static cab_ULONG fci_get_checksum(const void *pv, UINT cb, CHECKSUM seed)<BR>> > > case 2:<BR>> > > ul |= (((ULONG)(*pb++)) << 8);<BR>> > > case 1:<BR>> > > - ul |= *pb++;<BR>> > > + ul |= *pb;<BR>> > > default:<BR>> > > break;<BR>> > > }<BR>> > <BR>> > Is there any reason that you ignored 2 similar cases above?<BR>> <BR>> Yes, because it would be wrong ... Its a Duffs Device, falling through<BR>> to the last case. The other pb++ are necessary.<BR>> <BR>> Ciao, Marcus<BR>
<BR>
yes only the last one is dead. although i have to ask you guys, today i think i messed up on this one and it's a false positive, because at the beggining pb = pv.<BR>
so it will affect the pv and this shouldn't be applied right?<BR><BR><br /><hr />Conhe�a j� o Windows Live Spaces, o site de relacionamentos do Messenger! <a href='http://www.amigosdomessenger.com.br' target='_new'>Crie j� o seu!</a></body>
</html>