On Sun, Jan 25, 2009 at 11:25 AM, Massimo Del Fedele <span dir="ltr"><<a href="mailto:max@veneto.com">max@veneto.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Erich Hoover ha scritto:<br>
<div class="Ih2E3d">><br>
> I haven't looked into your implementation in much detail (I need more<br>
> hours in a day, I swear), but would it be possible to pass all the stubs<br>
> on so that unimplemented functionality still works even if it's dog<br>
> slow? It'd be nice if we could take advantage of the implemented<br>
> features, still be able to handle everything, and then spew a "FIXME:<br>
> Help Wine run faster by implementing this function in the DIB engine!"<br>
> for features that are not handled yet. (yeah, yeah, I want my cake and<br>
> be able to eat it too)<br>
><br>
> Erich Hoover<br>
</div>> <a href="mailto:ehoover@mines.edu">ehoover@mines.edu</a> <mailto:<a href="mailto:ehoover@mines.edu">ehoover@mines.edu</a>><br>
><br>
<br>
Well, by now many functions are stubbed (with disabled FIXMEs for<br>
speed), and 3 apps I've tested on it works ok.<br>
Some bad graphics, but mostly usable.<br>
You can test it easily and, if you like, you can enable all the stubs<br>
FIXMEs uncommenting a #define on header file.<br>
<br>
Ciao<br>
<br>
Max<br>
<br></blockquote></div><br>What I was trying to say is if you could have something like this for all the stubs:<br>
----<br>
BOOL DIBDRV_AlphaBlend( DIBDRVPHYSDEV *devDst, INT xDst, INT yDst, INT widthDst, INT heightDst,<br>
DIBDRVPHYSDEV *devSrc, INT xSrc, INT ySrc, INT widthSrc, INT heightSrc,<br>
BLENDFUNCTION blendfn)<br>
{<br>
FIXME("reverting to slow behavior!\n");<br>
return TheOldBehavior->AlphaBlend(...);<br>
}<br>----<br>
<br>
While I'm obviously not greatly familiar with this code, it seems like
the engine would have a better chance of being successful if
unimplemented features fell back to the old behavior. It seems like that would allow you to gradually transition over to the integrated DIB engine a little bit at a time, rather than having a lot of unavailable features that would all need to be implemented before the integrated DIB engine could be turned on for everyone. Even if you had to create a special surface and copy the bitmap back and forth every time you had to revert to the old behavior it seems like it would at least provide a good testbed.<br>
<br>Erich Hoover<br><a href="mailto:ehoover@mines.edu">ehoover@mines.edu</a><br>