<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
</style>
</head>
<body class='hmmessage'>
<br><br>> From: kai.blin@gmail.com<br>> To: robertshearman@gmail.com<br>> Subject: Re: gdi32: Remove unneeded check. (Coverity)<br>> Date: Wed, 28 Jan 2009 10:32:40 +0100<br>> CC: wine-devel@winehq.org<br>> <br>> On Tuesday 27 January 2009 18:29:10 Rob Shearman wrote:<br>> <br>> > It doesn't make much sense to leave the lcdfilter variable in the<br>> > function if you're going to remove the if condition depending on it,<br>> > since it only has one other use.<br>> > However, It might have been the intention of the author of this code<br>> > that this is setting to be changed at compile time (or runtime through<br>> > a registry tweak) and have the code do the appropriate thing - in that<br>> > case it would have been better to put the variable at the top of the<br>> > file.<br>> <br>> I actually have no idea. This was the smallest possible fix that addressed the <br>> coverity issue, but I agree that we need to do something with the lcdfilter <br>> variable.<br>> <br>> Looking at the commits responsible for the lcdfilter assignment (028617b9) and <br>> the if check (45a081f1), I don't see anything that hints at why there's an if <br>> check with lcdfilter hardcoded. CCing the original author.<br>> <br>> Cheers,<br>> Kai<br>> <br>> -- <br>> Kai Blin<br>> WorldForge developer http://www.worldforge.org/<br>> Wine developer http://wiki.winehq.org/KaiBlin<br>> Samba team member http://www.samba.org/samba/team/<br>> --<br>> Will code for cotton.<br><br /><hr />Hotmail� goes where you go. On a PC, on the Web, on your phone. <a href='http://www.windowslive-hotmail.com/learnmore/versatility.aspx#mobile?ocid=TXT_TAGHM_WL_HM_versatility_121208 ' target='_new'>See how.</a></body>
</html>