Hi Hans,<br><br>I have run the patch against my application and the line-styles draw as far as I can tell are the same as on Windows when a single line segment where the pixel width of one is used.<br><br>However when a polyline is drawn the dash style does not get drawn correctly. There seems to be an issue with repeat of the style when the pixel width of the line is increased. It looks like the style gets multiplied up.<br>
<br>I've not looked too deeply into this, however it looks like all pen styles are affected by the requested line width.<br><br>I also have an issue with the standard styles as they are defined as I belive they are not correct. I'm comparing on a pixel to pixel basis between Windows and Wine. However your patch does not affect this. I just wished to make you aware. When I have a sample to demonstrate this I will raise a bug report.<br>
<br>I've made some additional comments below on the patch and on the platforms supporting PS_USERSTYLE.<br><br>In addition there is also the odd even count for the bits that needs to be dealt with. However in most cases I doubt this would be an issue.<br>
<br><br>I'm also a bit of a newbie here and am not exactly sure how to advance this patch.<br><br>I can create a simple Win32 test which demonstrates the behaviour I am looking for. Of course the Windows results will be a screenshoot which will have to be compared against the test running under Wine.<br>
<br>Where would I post this sample?� (no guarentees on how long it's going to take me as I'm still trying to write a series of alpha blend tests).<br><br>Regards<br>Damian<br><br><br><br><br><br><div class="gmail_quote">
On Sat, Apr 4, 2009 at 9:49 PM, Hans Breuer <span dir="ltr"><<a href="mailto:hans@breuer.org">hans@breuer.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
just read again <a href="http://www.winehq.org/sending_patches" target="_blank">http://www.winehq.org/sending_patches</a> and noticed that my first wine patch may fall in the category of not deserving an answer at all (to your standards).<br>
<br>
The one thing I noticed is my mail client putting line-wrapping into the patch, which should be easy to correct.<br>
<br>
But before resending it, I would appreciate some feedback if something else is 'obviously' wrong with it. To me it seems to be very difficult for the issue at hand to fall into the category of being "Obvious(ly) Correct".<br>
<br>
Although the X11 and win32 concepts of extended line styles are very similar, at least I did not know the scaling issues involved without trying it out.<br>
<br>
One thing which may be considered critical is my selection of the test program. As noted it is Dia for win32 (ported by me [1]) through gdk-win32-drawing code (PS_USERSTYLE usage implemented by me [2]).<br>
So if I have misunderstood something there seven years ago, that two bugs could compensate each other ;)<br>
<br>
Another issue might be the unconditional implementation of PS_USERSTYLE. After all it is only available with NT-based windows. Should x11drv check for the version being emulated to also reproduce the failing behaviour? Or would that be too much compatibility?<br>
</blockquote><div><br>PS_USERSTYLE is available on all the systems I am currently using: 2000, XP & Vista.<br><br>�<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
What can I do to increase the probability of the patch being accepted?<br>
<br>
Thanks,<br>
� � � �Hans<br>
<br>
[1] <a href="http://hans.breuer.org/dia/" target="_blank">http://hans.breuer.org/dia/</a><br>
[2] <a href="http://svn.gnome.org/viewvc/gtk%2B?view=revision&revision=6330" target="_blank">http://svn.gnome.org/viewvc/gtk%2B?view=revision&revision=6330</a><br>
[3] <a href="http://hans.breuer.org/dia/dia-wine.htm" target="_blank">http://hans.breuer.org/dia/dia-wine.htm</a><br>
<br>
-------- Original-Nachricht --------<br>
Betreff: implement PS_USERSTYLE handling, tested with Dia(win32)<br>
Datum: Sun, 29 Mar 2009 19:45:05 +0200<br>
Von: Hans Breuer <<a href="mailto:hans@breuer.org" target="_blank">hans@breuer.org</a>><br>
An: <a href="mailto:wine-patches@winehq.org" target="_blank">wine-patches@winehq.org</a><br>
<br>