For my curiosity, why can't we use /proc for card detection?<br><br>If the right thing to do is create a device string database, then it seem the registry override patch is the way to go. This way, the bug is addressed today and users can move on. In the future, when the device string database is in place, there will be cases where we get it wrong, and the users will still want the ability to override the autopicked settings.<br>
<br>Does this sound reasonable? Do other devs agree?<br><br>John<br><br><br><div class="gmail_quote">On Wed, Apr 8, 2009 at 12:58 AM, Roderick Colenbrander <span dir="ltr"><<a href="mailto:thunderbird2k@gmail.com">thunderbird2k@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Hi John,<br><br>First of all this are basically two changes in one patch. Keep the vendor one separated from the device string. Second the opengl renderer string shouldn't be directly returned. In short d3d apps can query the pci id and opengl doesn't expose it (we aren't allowed to use /proc for card detection or so) and for that reason we 'estimate' what card is used based on the gpu capabilities (supported opengl extensions) and later on also the renderer string to refine the result a bit. For this reason the renderer string doesn't have to be the same as the pci id that we report. There are still some changes I have to make to the code and add a device string database.<br>
<font color="#888888">
<br>Roderick</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Wed, Apr 8, 2009 at 8:40 AM, John Whitlock <span dir="ltr"><<a href="mailto:John-Whitlock@ieee.org" target="_blank">John-Whitlock@ieee.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Use the OpenGL renderer for the device description<br>
Use the OpenGL vendor to pick an appropriate XP device driver<br>
Fixes bug 15839<br>
<br>
The registry overrides seemed to make devs uncomfortable, so I'm trying<br>
submitting without them. They are easy enough to add on top of this change,<br>
if the need arises in the future.<br>
<br>
<br><br>
<br></blockquote></div><br>
</div></div></blockquote></div><br>