<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 05/30/2009 12:59 PM, <a class="moz-txt-link-abbreviated" href="mailto:wine-devel-request@winehq.org">wine-devel-request@winehq.org</a> wrote:
<blockquote cite="mid:mailman.2.1243702799.18708.wine-devel@winehq.org"
type="cite">Ben Klein ha scritto:
<br>
<br>
<blockquote type="cite" style="color: rgb(0, 0, 0);"><br>
You would be surprised at how much of Wine is NOT a hack internally.
<br>
Wine doesn't do hacks,
<br>
</blockquote>
<br>
Well, well.... there are some, indeed.
<br>
Of course, it's better not add new ones <span class="moz-smiley-s1"
title=":-)"><span>:-)</span></span>
<br>
<br>
hence AJ's reluctance to include the current
<br>
<blockquote type="cite" style="color: rgb(0, 0, 0);">DIB proposal in
Wine (to make it "correct" later will require a lot of
<br>
hacking, as Max has objected).
<br>
</blockquote>
<br>
Again, my engine isn't a hack. Nor you'll need hacks to embed it on
gdi32.
<br>
Even more, some parts will be simplified because of direct access to
internal
<br>
gdi32 structures, which can't be done (without hacks....) in current
implementation.
<br>
The <b class="moz-txt-star"><span class="moz-txt-tag">*</span>only<span
class="moz-txt-tag">*</span></b> semi-hack is the direct access of
gdifont struct from inside winedib....
<br>
it could also be avoided, but with much useless code added.
<br>
Useless because it will be so once embedded in gdi32.
<br>
<blockquote type="cite" style="color: rgb(0, 0, 0);"><br>
<blockquote type="cite" style="color: rgb(0, 0, 0);">Do we even
have an architectural document or guidelines to reference?
<br>
</blockquote>
<br>
This was also raised on the existing thread. No. This is a problem.
<br>
The best we have so far is "DIB engine should be integrated into
<br>
GDI32". This is not a problem, because both Max and AJ share this
<br>
goal, but if I understand correctly, Max doesn't want to invest the
<br>
effort (which is a lot) until the current design is validated by
<br>
inclusion into upstream source.
<br>
</blockquote>
<br>
You got exactly the point <span class="moz-smiley-s1" title=":-)"><span>:-)</span></span>
<br>
To be precise, the effort isn't so huge, but summed with the effort of
maintaining
<br>
all in sync with current tree the global effort would be great (and
dumb, imho).
<br>
<blockquote type="cite" style="color: rgb(0, 0, 0);"><br>
<br>
Welcome aboard! I suggest that if you'd like to help out with the DIB
<br>
engine (with the goal of getting it included to Wine upstream source),
<br>
that you take a look at the code on bugzilla page #421 and talk to
<br>
Massimo about how you might adapt it for integration into GDI32.
<br>
<br>
</blockquote>
There's not too much to adapt.... moving the engine inside gdi32 is
(IMHO)
<br>
not complicated at all. More a writing effort than a coding one.
<br>
But, <b class="moz-txt-star"><span class="moz-txt-tag">*</span>before<span
class="moz-txt-tag">*</span></b>, I guess winex11.drv (and any
possible driver that does DIBs internally)
<br>
should be patched stripping DIB handling <b class="moz-txt-star"><span
class="moz-txt-tag">*</span>and<span class="moz-txt-tag">*</span></b>
adding some stuffs for mixed transfers.
<br>
Again, not an huge work, for somebody that knows well drivers
internals.
<br>
It could also be done later, if wished... but logically that would be
the first step.
<br>
<br>
Ciao
<br>
<br>
Max
<br>
<br>
<br>
</blockquote>
Ok Max then document what you think the effort would be and what is
needed to migrate your DIB engine into GDI32<br>
Then We could send it to AJ for approval and go from there. This would
be documenting the Delta which should <br>
allow AJ to go line item by line item and say yes or no to each or what
needs to do. How long would that take<br>
you to do Max? Once that is done we would have a defined plan etc and
going forward it would be documented.<br>
<br>
<br>
Chris<br>
<br>
</body></html>