<table cellspacing="0" cellpadding="0" border="0" ><tr><td valign="top" style="font: inherit;"><br><br>--- On <b>Sun, 10/4/09, Paul Vriens <i><paul.vriens.wine@gmail.com></i></b> wrote:<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><br>From: Paul Vriens <paul.vriens.wine@gmail.com><br>Subject: Re: kernel32/tests: Pass test on error code returned by Windows 7<br>To: dimaki@rocketmail.com<br>Cc: wine-devel@winehq.org<br>Date: Sunday, October 4, 2009, 4:20 AM<br><br><div class="plainMail">On 10/04/2009 09:10 AM, Dmitry Kislyuk wrote:<br>>> + ok( GetLastError() == 0xdeadbeef || GetLastError() == 2 /* Win 7 */,<br>>> + "expected 0xdeadbeef or 2, got %d\n", GetLastError());<br><br>>Don't use magic numbers, ERROR_FILE_NOT_FOUND would be better.<br><br>>-- Cheers,<br><br>>Paul.<br><br>Hi Paul,<br><br> All of the tests in this group
of tests are the same way. Magic
numbers instead of defines. I wanted to stay consistent with that. <br>
<br>
If Alexandre doesn't apply it I will resend with using ERROR_FILE_NOT_FOUND per your suggestion.<br><br>Thank you for looking at my patch.<br><br>Dmitry<br><br></div></blockquote></td></tr></table><br>