On Sat, Oct 10, 2009 at 2:52 PM, Vitaliy Margolen <span dir="ltr"><<a href="mailto:wine-devel@kievinfo.com" target="_blank">wine-devel@kievinfo.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div>...</div>
Why do you return a list of IP addresses from WS2_get_local_ips if you need<br>
only one? Just get the one with the lowest metric and return it.<br>
...<br></blockquote><div><br>Well, most applications only check for the first returned IP (the one with the highest priority, or the lowest metric).� However, from reading the knowledge base article the purpose of this "feature" of the routine is to return them all.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
...<br>
Here and everywhere else please put space before comas to follow the file's<br>
formatting.<br></blockquote><div><br>Sorry, I copied what I saw for HeapAlloc in the WS_gethostbyname routine (nearby).� Would you like a patch for updates to the spacing there as well?<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
...<br>
You do not need to check pointers for NULL before freeing them.<font color="#888888"><br></font></blockquote><div><br>Sorry, when I see "the behavior is undefined" in documentation I tend to shy away doing something.<br>
<br>Thanks for the feedback!<br><br><a href="mailto:ehoover@mines.edu">ehoover@mines.edu</a><br></div></div>Erich Hoover<br>