<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 2/5/2010 20:18, jose rostagno wrote:
<blockquote cite="mid:BLU119-W1F8518F8876B361AA9B1BC1540@phx.gbl"
type="cite">
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
--></style>implement
missing domcomment_replaceData<br>
</blockquote>
<blockquote type="cite">
<pre wrap="">+ if((offset == 0) || ((count + offset) >= len))
+ {
+ if(offset == 0){
+ IXMLDOMComment_substringData(iface, count, len - count, &str);
+ hr = IXMLDOMComment_put_data(iface, str);
+ if(hr == S_OK)
+ hr = IXMLDOMComment_appendData(iface, p);
</pre>
</blockquote>
This doesn't look right. You're appending replacement string to the
rest of initial string data,<br>
and offset == 0 means to replace from the start (if I didn't miss
something).<br>
<br>
Also we really need some tests here, and it's trivial to test here
(look at existing test I recently added<br>
for deleteData() for example). Especially test for a case count != (p
string length) is interesting.<br>
<br>
Minor things:<br>
- watch for indentation and please avoid tabs - most lines are indented
with spaces,<br>
- don't use 'if () {' style. The rest of this file uses '{' on the next
line,<br>
- correct your name in author filed to start with uppercase.<br>
<br>
<br>
</body>
</html>