<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type" />
<title></title>
</head>
<body>
<p> </p>
<div style="margin: 5px 0px 5px 0px; font-family: monospace;">
Alexandre Julliard <julliard@winehq.org> wrote:<br />
> Joel Holdsworth <joel@airwebreathe.org.uk> writes:<br />
><br />
> > @@ -188,6 +188,11 @@ filter: dummy<br />
> >  .man.in.man:<br />
> >          LC_ALL=C sed -e 's,@bindir\@,$(bindir),g' -e 's,@dlldir\@,$(dlldir),g' -e 's,@PACKAGE_STRING\@,@PACKAGE_STRING@,g' $< >$@ || ($(RM) $@ && false)<br />
> > <br />
> > +# Rules for icons<br />
> > +<br />
> > +ifdef SVG_SRCS<br />
> > +<br />
> > +# Depreciated icon build rule<br />
> >  .svg.ico:<br />
> >          $(RSVG) -w 16 -h 16 -f png $< $*-16.png<br />
> >          $(RSVG) -w 32 -h 32 -f png $< $*-32.png<br />
> > @@ -195,6 +200,17 @@ filter: dummy<br />
> >          $(ICOTOOL) -c -o $@ $*-16.png $*-32.png $*-48.png<br />
> >          $(RM) $*-16.png $*-32.png $*-48.png<br />
> > <br />
> > +else<br />
> > +<br />
> > +resources/%-32.png: resources/%.svg<br />
> > +        $(RSVG) -f png $< $@<br />
> > +<br />
> > +resources/%.ico : resources/%-*-4.png resources/%-*-8.png \<br />
> > +        resources/%-16-32.png resources/%-32-32.png resources/%-48-32.png<br />
> > +        $(ICOTOOL) -c -o $@ $^<br />
> > +<br />
> > +endif<br />
><br />
> That's GNU make specific, you can't do that.
</div>
<p style="margin: 0px;"> </p>
<p style="margin: 0px;">Yes I wondered if that might be the case. Do you (or anyone) have any thoughts about how to approach this? The .svg.ico suffix rule that's present at the moment works if there's a 1:1 relationship; one svg results in one ico. My problem is that a 9:1 relationship is required. Do you have any suggestions about how to make a generic rule to do that? Does it require changes to makedep?</p>
<p style="margin: 0px;"> </p>
<div style="margin: 5px 0px 5px 0px; font-family: monospace;">
> Also please don't send such a huge patch series. The first step should<br />
> be to get just one icon committed with the proper infrastructure. Then<br />
> you can consider sending more of them, preferably one dll at a time.
</div>
<p style="margin: 0px;">Sure - I can understand that. The reason I sent so many was that I wanted to show you that I don't plan to leave a depreciated SVG build rule lying around. I also wanted you to see and comment on my approach of creating resources subdirectories in these dlls like user32 has, and then putting the icon images in these.</p>
<p style="margin: 0px;"> </p>
<p style="margin: 0px;">What do you think?</p>
<br />
Joel Holdsworth<br />
</body>
</html>