<table cellspacing="0" cellpadding="0" border="0" ><tr><td valign="top" style="font: inherit;">Maybe this function should be in util.c.<br><br>A+<br><br>David<br><br><br>--- En date de : <b>Lun 19.4.10, Henri Verbeet <i><hverbeet@gmail.com></i></b> a écrit :<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><br>De: Henri Verbeet <hverbeet@gmail.com><br>Objet: Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests<br>À: wine-devel@winehq.org<br>Date: Lundi 19 avril 2010, 11h43<br><br><div class="plainMail">On 19 April 2010 09:43, Christian Costa <<a ymailto="mailto:titan.costa@wanadoo.fr" href="/mc/compose?to=titan.costa@wanadoo.fr">titan.costa@wanadoo.fr</a>> wrote:<br>> +BOOL is_pow2(UINT num)<br>> +{<br>> + UINT i;<br>> +<br>> + if (!num) return FALSE;<br>> + for (i = 0; num >> 1; i++) num
>>= 1;<br>> +<br>> + return (num << i) == num;<br>> +}<br>This should at least be static. You can also just replace it with<br>"return !(num & (num - 1));". You don't care about 0, since you<br>already check that earlier in D3DXCheckTextureRequirements().<br>make_pow2() can probably be simplified as well.<br><br><br></div></blockquote></td></tr></table><br>