Hi Alexander,<br><br><div class="gmail_quote">On Mon, Jun 21, 2010 at 21:52, Alexander Nicolaysen Sørnes <span dir="ltr"><<a href="mailto:alex@thehandofagony.com">alex@thehandofagony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Mandag 21. juni 2010 20.52.20 skrev Alexandru Băluț :<br>
<div><div></div><div class="h5">> Updated test_appData, because using downloadurl objects does not work<br>
> anymore, because appData.listSubmittedBy() ignores queued downloadurls.<br>
> I also fixed a bug in url.php: after creating an Url, the create function<br>
> does not update the object properly.<br>
><br>
<br>
</div></div>Hello,<br>
<br>
It's great that you're submitting patches! You could split this patch in two,<br>
since it contains two separate changes.<br></blockquote><div><br></div><div>I was thinking the changed test also works as a test case for the url.php change.. It does not matter, I'll resend.</div><div><br></div><div>
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Also, I see that you're using GIT to generate the patches. Could you do that<br>
with 'git format-patch -o out' and send the files generated in out/?<br></blockquote><div><br></div><div>What would be the improvement over the way I submitted the last 2 patches?</div><div><br></div><div>Thanks,</div>
<div>Alex</div></div>