<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div>
> - Misha; I told him tests were ok to submit during a code freeze; this is true,<br>
> given that Alexandre accepted tests as last as last Friday. 狢 should have<br>
> told him that tests which add stubs probably aren't ok, but he learned<br>
> that as soon as he submitted.<br>
> <a href="http://www.winehq.org/pipermail/wine-devel/2010-June/084632.html" target="_blank">http://www.winehq.org/pipermail/wine-devel/2010-June/084632.html</a><br>
> so that seems fine.<br>
><br>
</div>From the look of things Misha will be ok, but I imagine he would have<br>
been anyway.<br>
<br>
But there are also cases like e.g.<br>
<a href="http://bugs.winehq.org/show_bug.cgi?id=21233#c8" target="_blank">http://bugs.winehq.org/show_bug.cgi?id=21233#c8</a> where you completely<br>
miss the real issues in the patch, and instead recommend referring to<br>
a bug number in the commit log,<br></blockquote><div><br>Probably not my place to wade in here, but that's not true, he didn't mention the commit log:<br><br>"Be sure to mention in the post that it fixes <br>
<pre><span><a href="http://bugs.winehq.org/show_bug.cgi?id=21233" title="CLOSED FIXED - Anarchy Online crashes in a certain room in every Alien Mission (missions cannot be done)" target="_blank">http://bugs.winehq.org/show_bug.cgi?id=21233"</a></span></pre>
</div></div><br>I'm pretty sure he meant in the email when he emails wine-patches rather than in the commit log.<br><br>I've got to say Henri, I think you are being a little unfair here. Yes, possibly Dan has given flawed advice in the past, but it's nothing that a private email or chat on IRC wouldn't have solved.<br>
<br>Launching into a tirade against him publically isn't helping anything, all these instances are Dan trying to help out, quite obviously not to be "insidious" or to harm the project. <br><br>Luke.<br>