<div class="gmail_quote">On Sat, Jul 17, 2010 at 11:32 PM, Dmitry Timoshkov <span dir="ltr"><<a href="mailto:dmitry@codeweavers.com">dmitry@codeweavers.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
</div>Testing other values besides 0 would be helpful, in particular values like<br>
sizeof(class) - 1 and sizeof(class) + 1. Did you inspect all the places<br>
in Wine which call RegisterClassEx()? Also, GetClassInfoEx() in Wine is an<br>
obvious offender, and this needs a test (and a fix) too.<br><br></blockquote><div>I checked all calls to RegisterClassEx and submitted patches that got accepted before the end of the code freeze.</div><div><br></div><div>
I just checked sizeof(class) - 1 and sizeof(class) + 1 on Windows XP and they also fail.</div><div>Surprisingly I found that GetClassInfoEx didn't touch cbSize (e.g. 0 stays 0, 0xdeadbeef stays 0xdeadbeef).</div><div>
I also checked the unicode version of GetClassInfoEx and RegisterClassEx, and both have the same behaviour.</div><div><br></div><div>Thanks for the advice. I'll add the tests for GetClassInfoEx.</div></div>