<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:times new roman,new york,times,serif;font-size:12pt">Some compilers complain about the lack of a return in a void function. Don't forget to add it in each void function.<br><br>A+<br><br>David<br><div><br></div><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;"><br><div style="font-family: arial,helvetica,sans-serif; font-size: 13px;"><font face="Tahoma" size="2"><hr size="1"><b><span style="font-weight: bold;">De :</span></b> Austin Lund <austin.lund@gmail.com><br><b><span style="font-weight: bold;">� :</span></b> Vitaliy Margolen <wine-devel@kievinfo.com><br><b><span style="font-weight: bold;">Cc :</span></b> wine-devel@winehq.org<br><b><span style="font-weight: bold;">Envoy� le :</span></b> Jeu 12 ao�t 2010, 8h 09min 44s<br><b><span style="font-weight: bold;">Objet :</span></b> Re: [PATCH 1/2]
dmime/tests: Added tests for IDirectMusicPerformance.<br></font><br>On 12 August 2010 15:48, Vitaliy Margolen <<a ymailto="mailto:wine-devel@kievinfo.com" href="mailto:wine-devel@kievinfo.com">wine-devel@kievinfo.com</a>> wrote:<br>> You can't test that. All you can test is that you got the IDirectMusicPort<br>> back or not. What exactly inside is irrelevant.<br>><br>> And if IDirectMusicPerformance8_PChannelInfo succeeds and you getting not<br>> null pDirectMusicPort back but it points to bogus data or is unchanged (as<br>> it is now), it's outright invalid behavior that should be fixed. No tests<br>> needed for that.<br><br>OK. How about this:<br><br>static void test_PChannelInfo(void)<br>{<br> IDirectMusicPort *pDirectMusicPort;<br> HRESULT hr;<br><br> pDirectMusicPort = NULL;<br> hr = IDirectMusicPerformance8_PChannelInfo(idmusicperformance,
0,<br>&pDirectMusicPort, NULL, NULL);<br> ok(hr == S_OK, "Failed to call PChannelInfo (%x)\n", hr);<br> todo_wine ok(pDirectMusicPort != NULL, "IDirectMusicPort not set\n");<br>}<br><br>I'll take on other comments and resubmit tomorrow as suggested.<br><br>Thanks.<br><br><br></div></div>
</div><br>
</body></html>