<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Thomas,<br>
<br>
On 9/3/10 1:19 AM, Thomas Mullaly wrote:
<blockquote
cite="mid:AANLkTim8xWS6NJFRXtJiQZkfeSqKK6u=5ZoTPeQiNn88@mail.gmail.com"
type="cite">
<div>---</div>
<div> dlls/urlmon/tests/uri.c | 22 ++++++++++++-</div>
<div> dlls/urlmon/uri.c | 80
++++++++++++++++++++++++++++++++++++++++++----</div>
<div> 2 files changed, 93 insertions(+), 9 deletions(-)</div>
<br>
</blockquote>
<pre wrap="">+static HRESULT setup_builder_properties(UriBuilder <b class="moz-txt-star"><span class="moz-txt-tag">*</span>builder, const Uri<span class="moz-txt-tag">*</span></b> uri) {
+ if(uri->fragment_start > -1) {
+ builder->fragment = heap_alloc((uri->fragment_len+1)*sizeof(WCHAR));
+ if(!builder->fragment)
+ return E_OUTOFMEMORY;
+
+ memcpy(builder->fragment, uri->canon_uri+uri->fragment_start, uri->fragment_len*sizeof(WCHAR));
+ builder->fragment[uri->fragment_len] = '\0';
+ builder->fragment_len = uri->fragment_len;
+ }
+
+ return S_OK;
+}
</pre>
<br>
I don't think it's a good idea. It should be possible to avoid
fetching all URI properties here. You can do it, eg. on demand, when
you get a call to GetFragment and the fragment is not everwriten by
SetFragment call. Thinking about it, the way these APIs work
suggests that Uri object should store null-terminated properties
that we could return here, but it may be too far conclusion.<br>
<br>
Jacek<br>
</body>
</html>