<p>There are still a few style issues with your patch. You have inconsistent spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few more "}else{"s. You also create a few blocks for no reason other than to get around the C declarations on top of block rule. Please organize these in tune with the surrounding code. Only create a "useless" block (ie a block without a control flow statement) if there is an #ifdef around it with other implementations. Also please don't do things like "if (x) { do {...} while(x); }".</p>
<p>More importantly you seem to be missing the tests for this.</p>
<p>(sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post)<br>
Mike.</p>
<div class="gmail_quote">On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" <<a href="mailto:rm@eightyfive.net">rm@eightyfive.net</a>> wrote:<br type="attribution">> Try 2:<br>> - Exchange Patches #2 and #3.<br>
> - Fix errors in formatting<br>> - Check that fopen succeeds, return default value otherwise<br>> - default return value is now 0 for all parser functions<br>> <br>> Try 3:<br>> - Add missing checks for valid processor mask and cache values<br>
> <br>> Try 4:<br>> - More comments in the parsing code<br>> - Some additional code cleanup<br>> <br>> ---<br>> dlls/ntdll/nt.c | 343 <br>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++<br>
> 1 files changed, 343 insertions(+), 0 deletions(-)<br>> <br></div>