<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 10/26/2010 01:41, Jacek Caban wrote:
<blockquote cite="mid:4CC5F9A3.8010205@codeweavers.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
On 10/25/10 10:38 PM, Nikolay Sivov wrote:
<blockquote cite="mid:4CC5EACD.2030908@codeweavers.com"
type="cite">Should help with <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://bugs.winehq.org/show_bug.cgi?id=22607">http://bugs.winehq.org/show_bug.cgi?id=22607</a>
<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
</pre>
</blockquote>
<br>
<pre wrap="">+ V_VT(&v) = VT_BSTR;
+ V_BSTR(&v) = SysAllocString(data);
- hr = node_put_value(node_obj, &v_data);
Allocating a string only because it's needed for VariantChangeType (back to the string) seems like a bad design. How about moving xmlNodeSetContent call (and supporting xmlChar_from_wchar) to separated function (node_set_content?) from node_put_value and call it directly here?
</pre>
</blockquote>
Agreed. New helper could use in some other places too.<br>
<blockquote cite="mid:4CC5F9A3.8010205@codeweavers.com" type="cite">
<pre wrap="">
Jacek
</pre>
</blockquote>
<br>
</body>
</html>