<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 1/18/11 7:31 PM, Erich Hoover wrote:
<blockquote
cite="mid:AANLkTimTrsaB0kBrhtOsv53LMHOrmjEmoihy+YgwPmLz@mail.gmail.com"
type="cite">On Tue, Jan 18, 2011 at 3:08 AM, Jacek Caban <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:jacek@codeweavers.com" target="_blank">jacek@codeweavers.com</a>></span>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
...<br>
I'm not sure what you mean by "hijack the IOleCommandTarget".
All we do is implementing client's IOleCommandTarget. It's
something different from document's one.</blockquote>
<div><br>
I understand that, but apparently the native implementation
(testing on the test bot WXPPROSP3) sends the command to the
client IOleCommandTarget instead of the document
IOleCommandTarget (at least under the conditions of the
webbrowser tests). That is what I mean by hijacking, the
command is going to the "wrong" target. My guess would be
that there is some sort of priority mechanism, though I have
no idea how it would work (except maybe "if there's a
client/container then send to that target, else send to the
document target).</div>
</div>
</blockquote>
<br>
That sounds reasonable.<br>
<br>
<blockquote
cite="mid:AANLkTimTrsaB0kBrhtOsv53LMHOrmjEmoihy+YgwPmLz@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div> I've attached a test where I disabled the
client/container, and you can see that it then gets passed
through (QueryStatusWB will return success instead of passing
through the client target and returning failure):<br>
<a moz-do-not-send="true"
href="https://testbot.winehq.org/JobDetails.pl?Key=8408">https://testbot.winehq.org/JobDetails.pl?Key=8408</a><br>
</div>
</div>
</blockquote>
<br>
Hmm, it means that another run of tests (at least required subset of
existing test_WebBrowser) with client's IOleCommandTarget disabled
would be interesting. Do you feel like writing it? Otherwise we'd
need at least a FIXME in this case.<br>
<br>
Jacek<br>
</body>
</html>