<br><br><div class="gmail_quote">2011/2/11 Krzysztof Nikiel <span dir="ltr"><<a href="mailto:knik00@gmail.com">knik00@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
2011/2/11 Dmitry Timoshkov <<a href="mailto:dmitry@codeweavers.com">dmitry@codeweavers.com</a>>:<br>
<div class="im">> Krzysztof Nikiel <<a href="mailto:knik00@gmail.com">knik00@gmail.com</a>> wrote:<br>
><br>
</div><div class="im">>> > You can't send Makefile changes separately from added/removed<br>
>> > files, a patch should not add dead code.<br>
>><br>
</div>>> Could you explain "dead code", all 13 parts need to be applied,<br>
>> otherwise the code will be broken.<br>
><br>
> Wine should compile and be able to pass 'make test' after each separate patch.<br>
> You can't add for instance dlls/dsound/resample.c in one patch, and add it to<br>
> Makefile or use interfaces provided by it in some later patches. Every patch<br>
> should be finished and self-containing.<br>
<br>
Well, previous version of this patch was rejected as "needs<br>
splitting", it's basically too big to be send as a single patch. It<br>
can be applied as several smaller chunks or rejected as a whole. I<br>
don't think there is any other option.<br>
<br>
<br>
</blockquote></div><br><div>still, what dmitry told you still holds. wine needs to be able to compile and pass the tests after each patch is applied. at least the makefile changes should be merged with the previous patches that needs them (1 and 2). the rest seems like fine splitting, although i don't know the code.</div>
<div>what i'm not sure is, if resampler is still not called after the first patches, if it is fine to send those first patches... i think you also need to call resampler for the patch to be accepted, even if it is just as a stub, incomplete version.</div>