<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
OK, actually it looks like the problem is already in
X11DRV_SelectPen and is unlikely to occur, so my patches are good.<br>
<br>
Still, I'm thinking that if GetObjectW fails (<a
href="http://source.winehq.org/source/dlls/winex11.drv/pen.c#L45">http://source.winehq.org/source/dlls/winex11.drv/pen.c#L45</a>)
then we should immediately exit the function returning zero rather
than mucking around any further, setting the pen's ext field to
zero, etc. Then PEN_SelectObject (<a
href="http://source.winehq.org/source/dlls/gdi32/pen.c#L220">http://source.winehq.org/source/dlls/gdi32/pen.c#L220</a>)
wont replace the current pen with the uninitialized data. I realize
this perhaps "shouldn't fail" after a successful call to
GDI_inc_ref_count, but it still seems more responsible.<br>
<br>
Daniel<br>
<br>
On 02/15/2011 01:37 AM, Daniel wrote:
<blockquote cite="mid:4D5A2D21.4070703@att.net" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
grr, please disregard previous patches. I've discovered a problem
that can lead to use of un-initialized values.<br>
<br>
Daniel<br>
<br>
On 02/15/2011 01:09 AM, Daniel wrote:
<blockquote cite="mid:4D5A26A9.40502@att.net" type="cite">
<pre wrap="">Clean up per Vitaliy's direction. Also found a FIXME comment that needed
to be removed.
Daniel
</pre>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
</pre>
</blockquote>
</blockquote>
</body>
</html>