<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 2/23/2011 19:28, Amine Khaldi wrote:
<blockquote cite="mid:4D6535AC.3080002@reactos.org" type="cite">CIDs
1581 and 1583.
<br>
</blockquote>
<blockquote type="cite">@@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc
(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam,<br>
<br>
case VK_UP:<br>
step = -1;<br>
+ break;<br>
case VK_DOWN:<br>
/* by default, step is 1 */<br>
oldItem = SendMessageW (infoPtr->hwndSelf,
CB_GETCURSEL, 0, 0);</blockquote>
This is wrong.<br>
<br>
<blockquote type="cite">@@ -2297,6 +2297,7 @@ static LRESULT
TOOLBAR_Cust_AvailDragListNotification(const CUSTDLG_INFO *custIn<br>
TOOLBAR_Cust_AddButton(custInfo, hwnd, nIndexFrom,
nIndexTo);<br>
}<br>
}<br>
+ break;<br>
case DL_CANCELDRAG:<br>
/* Clear drag arrow */<br>
DrawInsert(hwnd, hwndList, -1);</blockquote>
Why? Looks to me it's fine to clear on dropped case too. Coverity is
a bit paranoid about missed breaks.<br>
<br>
Also don't include completely unrelated changes to one patch.<br>
<blockquote cite="mid:4D6535AC.3080002@reactos.org" type="cite">
<br>
Regards,
<br>
Amine.
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
</pre>
</blockquote>
<br>
</body>
</html>