Thanks for the feedback. What do you mean by "you are forcing a particular vertex ordering3"?<br>I just test the vertex that D3DXCreateBox sent. I think it is not possible to choose the ordering of the vertices for D3DXCreateBox. Did I miss anything?<br>
<br>A+<br><br>David <br><br><div class="gmail_quote">2011/3/9 Matteo Bruni <span dir="ltr"><<a href="mailto:matteo.mystral@gmail.com">matteo.mystral@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
2011/3/9 David Adam <<a href="mailto:david.adam.cnrs@gmail.com">david.adam.cnrs@gmail.com</a>>:<br>
<div><div></div><div class="h5">> Hello,<br>
><br>
> is there any problem with my d3dxcreatebox patch?<br>
><br>
> Thanks in advance for any feedback.<br>
><br>
> A+<br>
><br>
> David<br>
><br>
<br>
</div></div>Do you refer to <a href="http://source.winehq.org/patches/data/71983" target="_blank">http://source.winehq.org/patches/data/71983</a> ? I just<br>
had a cursory look at it: I presume there isn't anything fundamentally<br>
broken with your patch (you are forcing a particular vertex ordering,<br>
however that shouldn't be a problem for the D3DXCreateBox<br>
implementation) but, for sure, code style and formatting should be<br>
fixed.<br>
I know mesh.c is already quite bad in that regard, but that doesn't<br>
mean it needs more loose code. For example, in your patch there isn't<br>
a consistent usage of whitespace-after-comma, the same for spaces<br>
around operators or between the "if" and its condition. To compare<br>
expected and actual vertex data you should probably use the<br>
compare_vec3() function. Also, are "vertice", "normale" and "indice"<br>
Italian words? That doesn't look right. :) (also, the first vertex<br>
component is the position, not really "vertex")<br>
</blockquote></div><br>