<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>Am 23.08.2011 um 00:53 schrieb Henri Verbeet:</div><blockquote type="cite"><div>On 23 August 2011 00:38, Stefan Dösinger <<a href="mailto:stefandoesinger@gmx.at">stefandoesinger@gmx.at</a>> wrote:<br><blockquote type="cite"><blockquote type="cite">How is WINED3DFMT_D24_UNORM different from WINED3DFMT_X8D24_UNORM?<br></blockquote></blockquote><blockquote type="cite">It has a different application-visible ddraw format.<br></blockquote>I'm not sure that really justifies adding duplicate formats in<br>wined3d.</div></blockquote>I see 3 alternatives:</div><div><br></div><div>1) Just change the ddraw pixelformat for X8D24. That would be covered by test results from some Windows HW(Radeon 9000M, WinXP), but we might break some games</div><div><br></div><div>2) Leave the status quo and blame bug 22434 on the app. That would be covered by test results from another Windows machine(Radeon X1600, WinXP)</div><div><br></div><div>3) Advertise both X8D24 versions if X8D24 is supported. Change <span class="Apple-style-span" style="font-family: Menlo; font-size: 11px; ">ddraw_surface_init to make sure we don't have to convert back from the wined3d format. Then, once device_parent_create_depth_stencil is gone, we'll never convert wined3d depth formats to ddraw formats and we can support both X8D24 versions in ddraw without having two versions in wined3d.<br></span><br><blockquote type="cite"><div>Also, calling this D24_UNORM violates wined3d format naming<br>conventions. D24_UNORM would be a 3 byte format without padding.<br></div></blockquote></div>The ddraw format is already wrong. It claims to be 3 byte without padding, but as the test shows it actually has 1 padding byte. I think at the heart of this issue is that driver vendors couldn't agree how to represent a 3 byte depth with one byte padding format in a DDPIXELFORMAT structure.<div><br><div><br></div></div></body></html>