<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 3/21/2012 09:24, Eric Culp wrote:
<blockquote
cite="mid:CAEiyzc3hFnQCyWZr+JVSz+LOcJeNP3LVm872NmQ4HQyKDGVThQ@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div class="HOEnZb">
<div class="h5">On Wed, Mar 21, 2012 at 2:59 AM, Nikolay Sivov
<span dir="ltr"><<a moz-do-not-send="true"
href="mailto:bunglehead@gmail.com" target="_blank">bunglehead@gmail.com</a>></span>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>On 3/21/2012 08:58, Eric Culp wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
The two functions have different return values on
windows for analogous inputs.<br>
Changed to match windows behavior.<br>
---<br>
dlls/shlwapi/url.c | 12 ++++++++++--<br>
1 file changed, 10 insertions(+), 2 deletions(-)<br>
</blockquote>
</div>
</div>
Please add some tests for that.<br>
<br>
</blockquote>
</div>
</div>
</div>
I think it's already covered by
<div><br>
<div>dlls/shlwapi/tests/url.c:672<br>
<div>res = pUrlGetPartA("hi", szPart, &dwSize,
URL_PART_SCHEME, 0);</div>
<div>ok (res==S_FALSE, "UrlGetPartA(\"hi\") returned
%08X\n", res);</div>
<div><br>
</div>
<div>and</div>
<div><br>
</div>
<div>dlls/shlwapi/tests/url.c:685</div>
<div>res = pUrlGetPartW(hiW, bufW, &dwSize,
URL_PART_SCHEME, 0);</div>
<div>todo_wine ok(res==S_OK, "UrlGetPartW(\"hi\") returned
%08X\n", res);</div>
<div><br>
</div>
</div>
</div>
<div>Line 686 was the one that previously triggered a todo.
Should the todo_wine be removed?</div>
</div>
</blockquote>
Yes, you should run 'make test' and get no errors after your
changes. If you fixed todo it should be removed, if you break
existing test you should fix your patch.<br>
<blockquote
cite="mid:CAEiyzc3hFnQCyWZr+JVSz+LOcJeNP3LVm872NmQ4HQyKDGVThQ@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div><br>
</div>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>