<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 6/12/2012 11:52, Ulrik Dickow wrote:<br>
</div>
<blockquote cite="mid:4FD7035D.5040206@gmail.com" type="cite">
<pre wrap="">Patch 1 of 2 from <a class="moz-txt-link-freetext" href="http://bugs.winehq.org/show_bug.cgi?id=26226">http://bugs.winehq.org/show_bug.cgi?id=26226</a> .
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
<br>
<blockquote type="cite">
<pre wrap="">+static void test_namespaces_change(int doc_version)
+{
+ IXMLDOMDocument *doc;
+ IXMLDOMElement *elem;
+ IXMLDOMNode *node;
+
+ VARIANT var;
+ HRESULT hr;
+ BSTR str;
+
+ /* create on element and try to alter namespace after that */
+ doc = (doc_version == 0 ?
+ create_document(&IID_IXMLDOMDocument) :
+ create_document_version(60, &IID_IXMLDOMDocument));
+ if (!doc) return;</pre>
</blockquote>
Please use something like CLSID array with every available Document
CLSID, instead of only testing 2 of them. There's a lot of examples
for that in saxreader.c. <br>
<br>
<blockquote type="cite">
<pre wrap="">+ test_namespaces_change(0);
+ test_namespaces_change(60);
free_bstrs();
}</pre>
</blockquote>
It's better to avoid nested test calls like that imho, you could
just add another call in main test list.<br>
<br>
<blockquote type="cite">
<pre wrap="">+static void test_namespaces_change(int doc_version)
+{
+ IXMLDOMDocument *doc;
+ IXMLDOMElement *elem;
+ IXMLDOMNode *node;</pre>
</blockquote>
...<br>
<blockquote type="cite">
<pre wrap="">+
+ IXMLDOMElement_Release(elem);
+ IXMLDOMDocument_Release(doc);
+}
+</pre>
</blockquote>
When this is running on all CLSIDs please add free_bstrs() here.<br>
<br>
<br>
<br>
</body>
</html>