<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 6/13/2012 17:42, Ulrik Dickow wrote:<br>
</div>
<blockquote cite="mid:4FD8A6E9.9060609@gmail.com" type="cite">
<pre wrap="">Here's a new version of the patch that follows all of your 3 requests:
Den 12-06-2012 13:11, Nikolay Sivov skrev:
</pre>
<blockquote type="cite">
<pre wrap="">[...]
Please use something like CLSID array with every available Document
CLSID, instead of only testing 2 of them. There's a lot of examples for
that in saxreader.c.
[...]
It's better to avoid nested test calls like that imho, you could just
add another call in main test list.
[...]
When this is running on all CLSIDs please add free_bstrs() here.
</pre>
</blockquote>
<pre wrap="">
Is it ok now?</pre>
</blockquote>
Yes, that's what I meant. Thanks.<br>
<blockquote cite="mid:4FD8A6E9.9060609@gmail.com" type="cite">
<pre wrap="">
Since it contains new functionality, namely test of more document
versions (CLSIDs) than before, it was necessary to change the Subject of
the patch. How do I make sure that the old patch changes status to
Superseded on <a class="moz-txt-link-freetext" href="http://source.winehq.org/patches/">http://source.winehq.org/patches/</a> ? E.g. use the old
subject with "(try 2)" added in the E-mail header, but the new Subject
inside the attachment?</pre>
</blockquote>
Don't worry too much about that, just send it with correct subject
and mention in mail body<br>
which patch is obsolete. Correct subject is more important
obviously.<br>
<blockquote cite="mid:4FD8A6E9.9060609@gmail.com" type="cite">
<pre wrap="">
Regards, Ulrik Dickow
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
<br>
<br>
</body>
</html>