<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 7/20/2012 16:02, Roman Dadkov wrote:<br>
</div>
<blockquote
cite="mid:ba5ecf0e2f01b059238d367b6abfeaa3@office.etersoft.ru"
type="cite">This patch adds additional check for the returned
results in the test for the function WNetGetUniversalNameA.
<br>
The following cases are checked:
<br>
1 transmission of an incorrect buffer size
<br>
2 transmission of an incorrect buffer pointer
<br>
3 transmission path to the file
<br>
Similar checks are carried out to call a function with parameter
REMOTE_NAME_INFO_LEVEL.<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
</blockquote>
<blockquote type="cite">
<pre wrap="">+ fail_size = sizeof(driveA) / sizeof(char) - 1; // buffer size is less than the path
</pre>
</blockquote>
I don't know if this will be accepted as is, but anyway don't use
cpp style comments in future.<br>
<blockquote type="cite">
<pre wrap="">+ if(drive_type == DRIVE_REMOTE)
+ todo_wine ok(ret == WN_NO_ERROR, "WNetGetUniversalNameW failed: %08x\n", ret);
+ else
+ todo_wine ok(ret == ERROR_NOT_CONNECTED, "WNetGetUniversalNameW gave wrong error: %08x\n", ret);
</pre>
</blockquote>
This is mostly matter of taste but in such cases you can use
todo_wine {} and place all test call inside.<br>
</body>
</html>