<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 7/27/2012 06:00, Austin English
wrote:<br>
</div>
<blockquote
cite="mid:CACC5Q1cLC-t_G53uDnMhACgV=bZLbvoxf+9A6fXx7axw6kguvw@mail.gmail.com"
type="cite"><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
<blockquote type="cite">
<pre wrap="">+ if ( !locale_name.matches )
+ return FALSE;
+ return TRUE;</pre>
</blockquote>
Considering recent cleanup of such constructs please return like
'return locale_name.matches != 0;' or something like that.<br>
<br>
<blockquote type="cite">
<pre wrap="">+static void test_IsValidLocaleName(void)
+{
+ static const WCHAR enW[] = {'e','n',0};
+ static const WCHAR enusW[] = {'e','n','-','U','S',0};
+ static const WCHAR zzW[] = {'z','z',0};
+ static const WCHAR zzzzW[] = {'z','z','-','Z','Z',0};
+ BOOL ret;</pre>
</blockquote>
Please iterate through test data so it could be easily extended in
future.<br>
<br>
Also it looks like duplication, please add some invalid locale names
tests for LocaleNameToLCID and if return 0 for example, simply use
it for validation (you'll get covered with LOCALE_NAME_USER_DEFAULT
things for example).<br>
<br>
</body>
</html>