<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><br><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><br>I agree with Rico. It's hard to find issues in your own code, which<br>makes it all the more important to check it thoroughly.<br><br>Still, at least try to be careful with the code style:<br><br>+static void RotateX(FLOAT *out, UINT order, FLOAT a, FLOAT *in)<br><br>I think it's better to only use lower case for the (private) function<br>name. Something like "rotatex" or "rotate_x" or whatever.<br><br>I can agree with the rotate name, but not with the X. X in capital is there to mean the X-axis. In math, one never uses a lower case letter for an axis. So, it would become hard to understand what means x.<br><br><br>+ if ( order <
2 )<br>+ return;<br><br>Please indent it correctly.<br><br>OK.<br><br>+ return;<br>+}<br><br>Unneeded.<br><br>One always said to me that it is a good pratice that a function returns something.....<br><br>+FLOAT* WINAPI D3DXSHRotate(FLOAT *out, UINT order, CONST D3DXMATRIX<br>*matrix, CONST FLOAT *in)<br><br>Fix the FLOAT*.<br><br>I don't understand.<br><br>+ return;<br>+}<br><br>Again.<br><br>Also, the patch is full of trailing whitespaces, please fix those too.<br><br>OK<br><br>Nozomi<br> </div> </div> </div></body></html>