<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt">Hi<br><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><div id="yiv1633659880"><div><div style="color:#000;background-color:#fff;font-family:times new roman, new york, times, serif;font-size:12pt;"><br>Both your patch and mine fail to pass the attached tests. More thoughts are needed.<br><br>Nozomi<br><div><span><br></span></div><div><span></span></div><br><div style="font-family:times new roman, new york, times, serif;font-size:12pt;"><div style="font-family:times new roman, new york, times, serif;font-size:12pt;">>Hi Nozomi,<br>><br>>the huge arrays, the loop, it looks a bit ugly. Your implementation makes the D3DXSHRotateZ function a >bit more compatible. What comes into my mind
is:<br>>D3DXSHRotateZ(out, y, 1,25f, in);<br>>D3DXSHRotateZ(out, y, 1,25f, out);<br>>D3DXSHRotateZ(out, y, 1,25f, &out[x]); // x ... 1 - y * y<br>>D3DXSHRotateZ(&out[x], y, 1,25f, out); // x ... 1 - y * y<br>><br>>Do the last 2 also work and are they producing the same values as
native?<br>><br>>Attached is a simple hack to succeed your test, it has some major stuff which needs to be fixed first, but >nevertheless, please have a look. I think the implementation could be a lot smaller and faster. What do you >think? I'd like to hear your opinion, before you try to send a patch.<br>><br>>+FLOAT * WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in)<br>>There is a double space after "order,".<br>><br>>Cheers<br>>Rico<br><br><br> </div> </div> </div></div></div><meta http-equiv="x-dns-prefetch-control" content="on"><br><br> </div> </div> </div></body></html>