<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>Your patch pass the tests. Good.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span>I think my additionnal tests are enought for now. They prove really well what it happens for this function.<br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span>I let you send your patch. I will send the tests when your patch is committed.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new
roman,new york,times,serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span>Can you use j++ instead of ++j. Like this, it will be as the other loops for spherical harmonics part.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: times new roman,new york,times,serif; background-color: transparent; font-style: normal;"><span>Nozomi.<br></span></div><br><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;">On 17.10.2012 08:35, Nozomi Kodama wrote:<br>> My
bad.<br>> <br>> My patch pass the tests but not yours. Can you check these facts?<br>> <br>> Nozomi<br><br>Oups, I didn't respect the order while setting the output values. Splitting the loop and starting with the smallest index should make the behavior exactly the same as yours (I think). Something like the attached should fix it, please have a look. Though we may use a test for D3DXSHRotateZ(&out[x], y, 1,25f, out)... as of the function gets smaller ... we may generate our expected values by hand. That way we can run all combinations. Not sure if it is worth the effort.<br><br>Cheers<br>Rico<br><br><br> </div> </div> </div></body></html>