<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Le 18/10/2012 22:27, Rico Schüller a
écrit :<br>
</div>
<blockquote cite="mid:5080663F.2040908@web.de" type="cite">On
18.10.2012 21:05, Daniel Santos wrote:
<br>
<blockquote type="cite">On 10/16/2012 01:12 PM, Christian Costa
wrote:
<br>
<blockquote type="cite">+ /* Choose point inside the client
area */
<br>
+ point.x = rect.right / 2 - 50;
<br>
+ point.y = rect.bottom / 2 - 50;
<br>
+ ret = ScreenToClient(wnd, &point);
<br>
+ ok(ret, "ScreenToClient failed with %#x\n",
GetLastError());
<br>
+ ret = MapWindowPoints(NULL, wnd, &point, 1);
<br>
+ ok(ret, "MapWindowPoints failed with %#x\n",
GetLastError());
<br>
+
<br>
+ /* Choose point outside the client area */
<br>
+ point.x = rect.right / 2 + 50;
<br>
+ point.y = rect.bottom / 2 + 50;
<br>
+ ret = ScreenToClient(wnd, &point);
<br>
+ ok(ret, "ScreenToClient failed with %#x\n",
GetLastError());
<br>
+ ret = MapWindowPoints(NULL, wnd, &point, 1);
<br>
+ ok(ret, "MapWindowPoints failed with %#x\n",
GetLastError());
<br>
</blockquote>
When I do these tests, I like throwing every stupid thing I can
possibly
<br>
come up with (and I'm gifted and coming up with stupid things)
but
<br>
always get shot down because I can't produce an example of a
real-world
<br>
app doing it. So here's one from LoTRO:
<br>
<br>
8.385:0009:Call user32.ScreenToClient(00000000,0033fd68)
ret=006d4d87
<br>
<br>
And if you don't return zero when it does this, the game crashes
<br>
resulting in my in-box filling up from desperate game addicts
posting to
<br>
appdb.
<br>
<br>
So if you can please include the below in your patch, I can omit
it from
<br>
mine (see <a class="moz-txt-link-freetext" href="http://bugs.winehq.org/show_bug.cgi?id=31979">http://bugs.winehq.org/show_bug.cgi?id=31979</a>) and
thank you!
<br>
<br>
+ /* LoTRO will do this and crash if we don't return zero,
precious indeed! */
<br>
+ ret = ScreenToClient( NULL, &point );
<br>
+ ok(!ret, "ScreenToClient didn't fail as expected (got
%d)\n", ret);
<br>
<br>
Daniel
<br>
<br>
</blockquote>
Please, be a bit more patient. The problem is known since end of
August and no one filed a bug for it. Even I asked the guy in
#winehq after creating the initial hack to file a bug for it.
(Someone with a log from the channel from 29/30. August might look
up the details / logs) I didn't send the patch, because it's only
a hack and I wasn't able to produce a nice test case and later
forgot about it.
<br>
<br>
I was stuck at the different returned point results for different
win versions (see
<a class="moz-txt-link-freetext" href="https://testbot.winehq.org/JobDetails.pl?Key=22315">https://testbot.winehq.org/JobDetails.pl?Key=22315</a> - I used
uitools instead of win there to get a smaller log). So someone
with some more knowledge in that area needs to gave a hint to make
a nice test. Nevertheless attached is my latest version of the
test and implementation, but be warned, it is still not ready to
be send to wine-patches.
<br>
<br>
If I remember correctly, lotro doesn't need the Get/SetLastError
part, but I added it anyway. It may be split out and added in a
later patch,
<br>
<br>
Cheers
<br>
Rico
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
Do you plan to work on you tests soon? Otherwise I can take a look
at them this week-end.<br>
</body>
</html>