<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Le 20/11/2012 13:31, Alexandre Julliard
a écrit :<br>
</div>
<blockquote cite="mid:87mwycxxps.fsf@wine.dyndns.org" type="cite">
<pre wrap="">Eric Pouech <a class="moz-txt-link-rfc2396E" href="mailto:eric.pouech@orange.fr"><eric.pouech@orange.fr></a> writes:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">That doesn't look right. There's no guarantee that the handle is for the
current process console.
</pre>
</blockquote>
<pre wrap="">in fact, it's guaranted, because we check before (in the function
calling this helper) that the handle is really a console handler and
that it's in bare mode
one could make it clearer by adding a comment to the helper function
saying that those two conditions are met
</pre>
</blockquote>
<pre wrap="">
That doesn't guarantee that it's the process console, console handles
can be passed across processes.
</pre>
</blockquote>
<font face="Helvetica, Arial, sans-serif">yes, but the base console
code is already broken wrt this point (we use the</font> current
process' console wait<br>
object instead of the wait object of the passed console)<br>
<br>
potential solutions ?<br>
- extending the server calls to support this behavior would break
rights enforcement. not good IMO.<br>
- seperate the process to read input from fd(0) and the current
running process<br>
(hence ensuring that we get the correct rights for writing)<br>
this is what we do with wineconsole (for other backends).
moving bare console to wineconsole<br>
could also other benefits, as ensuring that the process
controling the unix console doesn't<br>
die until the last wine process using it dies (and resetting
the terminal control at exit)<br>
- any other ideas ?<br>
<br>
A+<br>
</body>
</html>