<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-BOOL __cdecl FDIIsCabinet(<br>
- HFDI hfdi,<br>
- INT_PTR hf,<br>
- PFDICABINETINFO pfdici)<br>
+BOOL __cdecl FDIIsCabinet(HFDI hfdi, INT_PTR hf, PFDICABINETINFO pfdici)<br>
{<br>
BOOL rv;<br>
FDI_Int *fdi = get_fdi_ptr( hfdi );<br>
@@ -749,13 +746,13 @@ BOOL __cdecl FDIIsCabinet(<br>
if (!fdi) return FALSE;<br>
if (!hf) {<br>
- ERR("(!hf)!\n");<br>
+ WARN("No file handle\n");<br>
SetLastError(ERROR_INVALID_<u></u>HANDLE);<br>
return FALSE;<br>
}<br>
if (!pfdici) {<br>
- ERR("(!pfdici)!\n");<br>
+ WARN("No cab info pointer\n");<br>
SetLastError(ERROR_BAD_<u></u>ARGUMENTS);<br>
return FALSE;<br>
}<br>
</blockquote></div></div>
This call already has a TRACE earlier, I don't see a point in tracing input parameters multiple times.<div class="HOEnZb"><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br></blockquote></div></div></blockquote><div><br></div><div>Indeed. That would be better to remove them. Thanks. </div></div>