It probably makes sense to marking old one as broken, as E_NOTIMPL sounds better in this case. This could potentially break things of course if application checks for strict equality of the error code.<br><div class="gmail_extra">
<br><br><div class="gmail_quote">On Thu, Dec 13, 2012 at 8:02 AM, Detlef Riekenberg <span dir="ltr"><<a href="mailto:wine.dev@web.de" target="_blank">wine.dev@web.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
winetestbot crash sometimes in comdlg32:itemdlg on win7 or win2008,<br>
but that is independant from this win8 fix.<br>
<br>
<a href="http://test.winehq.org/data/tests/comdlg32:itemdlg.html" target="_blank">http://test.winehq.org/data/tests/comdlg32:itemdlg.html</a><br>
<br>
<br>
--<br>
By by ... Detlef<br>
---<br>
�dlls/comdlg32/tests/itemdlg.c | � �9 ++++++---<br>
�1 files changed, 6 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/dlls/comdlg32/tests/itemdlg.c b/dlls/comdlg32/tests/itemdlg.c<br>
index ce05ed8..7bffcbd 100644<br>
--- a/dlls/comdlg32/tests/itemdlg.c<br>
+++ b/dlls/comdlg32/tests/itemdlg.c<br>
@@ -278,13 +278,16 @@ static BOOL test_instantiation(void)<br>
� � � � �IShellBrowser *psb;<br>
<br>
� � � � �hr = IServiceProvider_QueryService(psp, &SID_STopLevelBrowser, &IID_IExplorerBrowser, (void**)&peb);<br>
- � � � �ok(hr == E_FAIL, "got 0x%08x.\n", hr);<br>
+ � � � �/* win8: E_NOTIMPL */<br>
+ � � � �ok(hr == E_FAIL || hr == E_NOTIMPL, "got 0x%08x.\n", hr);<br>
� � � � �if(SUCCEEDED(hr)) IExplorerBrowser_Release(peb);<br>
� � � � �hr = IServiceProvider_QueryService(psp, &SID_STopLevelBrowser, &IID_IShellBrowser, (void**)&psb);<br>
- � � � �ok(hr == E_FAIL, "got 0x%08x.\n", hr);<br>
+ � � � �/* win8: E_NOTIMPL */<br>
+ � � � �ok(hr == E_FAIL || hr == E_NOTIMPL, "got 0x%08x.\n", hr);<br>
� � � � �if(SUCCEEDED(hr)) IShellBrowser_Release(psb);<br>
� � � � �hr = IServiceProvider_QueryService(psp, &SID_STopLevelBrowser, &IID_ICommDlgBrowser, (void**)&punk);<br>
- � � � �ok(hr == E_FAIL, "got 0x%08x.\n", hr);<br>
+ � � � �/* win8: E_NOTIMPL */<br>
+ � � � �ok(hr == E_FAIL || hr == E_NOTIMPL, "got 0x%08x.\n", hr);<br>
� � � � �if(SUCCEEDED(hr)) IUnknown_Release(punk);<br>
� � � � �hr = IServiceProvider_QueryService(psp, &SID_SExplorerBrowserFrame, &IID_ICommDlgBrowser, (void**)&punk);<br>
� � � � �ok(hr == S_OK, "got 0x%08x.\n", hr);<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.5.4<br>
<br>
<br>
<br>
</font></span></blockquote></div><br></div>