<html><head></head><body>OK, but how do I know that the old behavior is broken ? WindowsXp behaves like msdn quotes while newer windows don't. Do you always assume that the latest implementation is correct ? Should wine just match the latest test-results and ignore osversioninfo at all ?<div><hr><div><strong>Von:</strong> "Dmitry Timoshkov" <dmitry@baikal.ru><br><strong>An:</strong> "Patrick Rudolph" <siro@das-labor.org><br><strong>Cc:</strong> "wine-devel@winehq.org" <wine-devel@winehq.org><br><strong>Gesendet:</strong> 11. Januar 2013 04:06<br><strong>Betreff:</strong> Re: kernel32/tests : try2 added tests for copyfileex<br></div><br><pre>Patrick Rudolph <siro@das-labor.org> wrote:
> try2:
> check the os version in case of PROGRESS_STOP
> + ret = GetFileAttributesEx(dest_name, GetFileExInfoStandard, (void*)&fileInfo);
> +
> + /* Windows Vista and newer delete the file, while prior versions don't */
> + ok((!ret && info.dwMajorVersion > 5) || (ret && info.dwMajorVersion <= 5),
> + "GetFileAttributesEx return-value wrong, got %u and MajorVersion is %u\n", ret, info.dwMajorVersion);
Then you should mark old behaviour as broken() and don't check Windows
version at all.
--
Dmitry.
</siro@das-labor.org></pre></div></body></html>