<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Detlef,<br>
<br>
On 03/03/2013 10:23 PM, Detlef Riekenberg wrote:<br>
</div>
<blockquote
cite="mid:trinity-48c40f01-170b-421f-8a76-d242a3d340f4-1362345804858@3capp-webde-bs43"
type="cite">
<div style="font-family: Verdana;font-size: 12.0px;">
<div>Hi Alexandre.<br>
</div>
<div><br>
</div>
<div>I have a test failure on my win7 Machine, while a valid cd
was in the dvd drive.<br>
</div>
<div><a moz-do-not-send="true"
href="http://source.winehq.org/git/wine.git/?a=blob;f=dlls/kernel32/tests/volume.c;hb=209b58c64e6181c9bf448cb4f3130d3ba705c5d2#l785"
target="_blank">volume.c:785</a>: Test failed:
IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last
error = 1785</div>
<div><br>
</div>
<div>Example result:<br>
</div>
<div><a moz-do-not-send="true"
href="http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_dr-w7sp1-wow-p6100/kernel32:volume.html"
target="_blank">http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_dr-w7sp1-wow-p6100/kernel32:volume.html</a><br>
</div>
<div>(The same failure is present, when running the 64bit test)<br>
</div>
<div><br>
</div>
<div>Other machines are also affected.<br>
</div>
<div>Example:<br>
</div>
<div><a moz-do-not-send="true"
href="http://test.winehq.org/data/4a685ebea343efdcb433f8d710b0c9f902e471fa/win7_matt/kernel32:volume.html"
target="_blank">http://test.winehq.org/data/4a685ebea343efdcb433f8d710b0c9f902e471fa/win7_matt/kernel32:volume.html</a><br>
</div>
</div>
</blockquote>
Error 1785 is ERROR_UNRECOGNIZED_MEDIA wich means "The disk media is
not recognized. It may not be formatted."<br>
All I can do is to add a skip() or maybe a broken() call to continue
the test.<br>
<br>
<blockquote
cite="mid:trinity-48c40f01-170b-421f-8a76-d242a3d340f4-1362345804858@3capp-webde-bs43"
type="cite">
<div style="font-family: Verdana;font-size: 12.0px;">
<div>You wrote the tests, which where comitted on 12. July 2012:<br>
</div>
<div>
<div><a moz-do-not-send="true"
href="http://source.winehq.org/git/wine.git/commitdiff/a3b5dd2dff0d04fe317f00282ccb0488e4803015"
target="_blank">http://source.winehq.org/git/wine.git/commitdiff/a3b5dd2dff0d04fe317f00282ccb0488e4803015</a><br>
</div>
<div><br>
</div>
<div>What media did you use, to test your code?<br>
</div>
<div>Data-DVD, Video-DVD, Empty DVD, Data-CD, Video-CD,
Audio-CD, Empty CD, No Disc in Drive<br>
</div>
<div>What results did you get on Windows and Unix?<br>
</div>
</div>
</div>
</blockquote>
As many developpers, I tried with things I had at home.<br>
I tested on a XP or 7 (I don't recall, maybe both) VM with a (Video)
DVD, a computer game (The Sims 3) DVD, a Ubuntu DVD version and I
also toyed with mkisofs to generate some ISO for me.<br>
And yes, I tested my patch on linux before sending it upstream.<br>
<br>
<blockquote
cite="mid:trinity-48c40f01-170b-421f-8a76-d242a3d340f4-1362345804858@3capp-webde-bs43"
type="cite">
<div style="font-family: Verdana;font-size: 12.0px;">
<div>
<div>
<div>On Linux, mounting the example CD works perfect, but
your test fails:<br>
</div>
volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE
(DvdPhysicalDescriptor) failed, last error = 87<br>
</div>
</div>
</div>
</blockquote>
Error 87 is ERROR_INVALID_PARAMETER wich is probably returned from <a
href="http://source.winehq.org/source/dlls/ntdll/cdrom.c#L2546">http://source.winehq.org/source/dlls/ntdll/cdrom.c#L2546</a>
meaning the ioctl() call failed for some reason.<br>
<br>
You know, this function is essentially a wrapper of ioctl() so if
you see a failure, you should have a look at /var/log/messages.<br>
You may also add a TRACE with strerror() to know exactly what
happens but I fear you would only get something like "Device not
supported" or "not ready" or something like that.<br>
<br>
<blockquote
cite="mid:trinity-48c40f01-170b-421f-8a76-d242a3d340f4-1362345804858@3capp-webde-bs43"
type="cite">
<div style="font-family: Verdana;font-size: 12.0px;">
<div>
<div>Your test only read the DVD descriptor.<br>
</div>
<div><br>
</div>
<div>To fix your test, I suggest, that you add a trace to dump
the<br>
</div>
<div> *_READ_STRUCTURE IoControl result and add similar tests<br>
</div>
<div> for the other media formats.<br>
</div>
<div><br>
</div>
<div>I also tested with a different Data-CD and got the same
failure on linux (last error = 87).<br>
</div>
<div><br>
</div>
<div>You can check the image yourself:<br>
</div>
<div><a class="moz-txt-link-freetext" href="http://www.memtest86.com/downloads/memtest86-4.1.0-iso.zip">http://www.memtest86.com/downloads/memtest86-4.1.0-iso.zip</a><br>
</div>
<div>(Burned on a CD)<br>
</div>
<div><br>
</div>
<div>That all winetest vm are missing optical media is a
different issue:<br>
</div>
<div><a class="moz-txt-link-freetext" href="http://bugs.winehq.org/show_bug.cgi?id=31780">http://bugs.winehq.org/show_bug.cgi?id=31780</a><br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
<div class="signature">-- <br>
By by ... Detlef<br>
</div>
<div class="signature"><br>
</div>
</div>
</blockquote>
Dumping may help you but as we only take the result of ioctl() to
feed the different fields of a structure, I don't really see what we
can do .. except modifying the code in the kernel to return what we
expect.<br>
</body>
</html>