<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Le 24/04/2013 23:35, Christian Costa a
écrit :<br>
</div>
<blockquote cite="mid:51785020.4000402@gmail.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Le 24/04/2013 20:10, James Eder a
écrit :<br>
</div>
<blockquote
cite="mid:CAP4VxRBq37w80VRK1-Xyin47sTTuoOc7_2-BKEhFN0tXStjedA@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Apr 24, 2013 at 6:58 AM,
Christian Costa <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:titan.costa@gmail.com" target="_blank">titan.costa@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_extra">Hi James,<br>
<div class="gmail_quote">
<div><br>
That would be better to change the trace at the
beginning by FIXME( "(%p, %d): semi-stub\n",
info, size ); or FIXME( "(%p, %d): partial
stub\n", info, size );<br>
</div>
<div>instead of adding another fixme (which is not
really correct since it's not a stub).<span
class=""><font color="#888888"><br>
<br>
</font></span></div>
<span class=""><font color="#888888">Christian<br>
</font></span></div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
Does this look better? <a moz-do-not-send="true"
href="http://source.winehq.org/patches/data/95866">http://source.winehq.org/patches/data/95866</a><br>
<br clear="all">
</div>
</div>
</blockquote>
<pre>- TRACE( "(%p, %d)\n", info, size );
+ FIXME("semi-stub (%p, %d)\n", info, size );</pre>
Wine sources used to put semi-stub mention after parameters. There
is also inconsistency with spaces near parenthesis. 0 before the
format string and 1 after size parameter.<br>
Something like FIXME("(%p, %d): semi-stub\n", info, size);<br>
Otherwise seems fine. :)<br>
<br>
</blockquote>
<pre>- if (status)
+ if(size < sizeof(PERFORMANCE_INFORMATION))
{
+
+ mem_status.dwLength = sizeof(mem_status);
+ if (!GlobalMemoryStatusEx( &mem_status ))
Oups. Forgot this one. Cosmetic again :|. Still space inconsitency. First if w/o and second w/ space.
Christian
</pre>
</body>
</html>