<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 7/9/2013 16:50, Qian Hong wrote:<br>
</div>
<blockquote cite="mid:51DC0700.20807@codeweavers.com" type="cite">Fixed
a crash in MS Office 2010 Chinese version.
<br>
Thanks Jiang Yike for the helps on testing :)
<br>
<br>
---
<br>
dlls/imm32/imm.c | 6 ++++++
<br>
dlls/imm32/tests/imm32.c | 13 +++++++++++++
<br>
2 files changed, 19 insertions(+)
<br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
<blockquote type="cite">
<pre wrap="">+ if (IsBadReadPtr(internal, sizeof(HIMCC)))
+ {
+ SetLastError(ERROR_INVALID_HANDLE);
+ return 0;
+ }
+</pre>
</blockquote>
<pre wrap="">Do you really need this for Office 2010 or null check is enough? If it's passing 0 handle here
that's what you should check imho. If HIMCC is really a handle and not a struct pointer like in wine,
that's not how a handle validity check will look like.
</pre>
<br>
</body>
</html>