<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span><br></span></div><div><br></div> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <hr size="1"> <font face="Arial" size="2"> <b><span style="font-weight:bold;">De :</span></b> Matteo Bruni <matteo.mystral@gmail.com><br> <b><span style="font-weight: bold;">À :</span></b> Nozomi Kodama <nozomi.kodama@yahoo.com> <br><b><span style="font-weight: bold;">Cc :</span></b> Wine Devel <wine-devel@winehq.org> <br> <b><span style="font-weight: bold;">Envoyé le :</span></b> Jeudi 1 août 2013 9h46<br> <b><span style="font-weight: bold;">Objet :</span></b> Re: d3dx9 [patch 1/2]: Implement D3DXCreatePolygon<br> </font> </div> <div
class="y_msg_container"><br>2013/8/1 Nozomi Kodama <<a ymailto="mailto:nozomi.kodama@yahoo.com" href="mailto:nozomi.kodama@yahoo.com">nozomi.kodama@yahoo.com</a>>:<br>><br><br>+ vertices = HeapAlloc(GetProcessHeap(), 0, 2 * (sides + 1) *<br>sizeof(D3DXVECTOR3));<br>+ if (!vertices)<br>+ {<br>+ TRACE("Not memory enough for vertex buffer\n");<br>+ polygon->lpVtbl->Release(polygon);<br>+ return E_OUTOFMEMORY;<br>+ }<br>+<br>+ hr = polygon->lpVtbl->LockVertexBuffer(polygon, D3DLOCK_DISCARD,<br>(VOID **)&vertices);<br><br>Why are you allocating memory and immediately dropping track of it?<br>Recheck how ID3DXMesh::LockVertexBuffer works.<br><br>It is a leftover of my tests about the requested size of the buffer :( ....<br><br>Also I'm having a deja-vu here, this patch looks suspiciously
similar<br>(up to having this same issue) to one I've already reviewed in the<br>past.<br>I don't understand what you mean here. Can you tell more?<br><br>I send a newer version. This one should be fine.<br><br>Nozomi.<br><br></div> </div> </div> </div></body></html>